Currently every 3 years for me. Normally it’s once the new models have enough added hardware features like better cameras, better microphones for video recording etc

It hasn’t been because my phone has been slow for many years because they’re at the point of being powerful even considering years of age.

I’ve only met one person who upgrades each year simply because a new phone is released yet myself and many others have iPhones.